Open msridhar opened 10 months ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 87.07%. Comparing base (
28cc318
) to head (7092ef6
).
Files | Patch % | Lines |
---|---|---|
.../src/main/java/com/uber/nullaway/ErrorBuilder.java | 50.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
FYI I am going to hold off on landing this, as I realized it doesn't completely fix the problems we were seeing. Once we figure out a plan for moving forward, I will land this PR (assuming it's part of that plan).
We were getting override errors in relation to the parameter of some Lombok-generated
equals()
method due to the fix in #874. This error is not reported with the latest version of Error Prone since it properly handles@SuppressWarnings("all")
, which is generated by Lombok (see https://github.com/google/error-prone/pull/4076). For compatibility with older Error Prone versions we add our own check for@SuppressWarnings("all")
.Getting a test case here required some work since this issue can only be reproduced on older Error Prone versions. We re-jigger some test projects to build against whatever Error Prone version is specified with
epApiVersion
, so that we catch issues like these in the future.