search

uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Revert "Model Lombok-generated equals methods as having a @Nullable p… #886

Closed msridhar closed 9 months ago

msridhar commented 9 months ago

…arameter (#874)"

This reverts commit 5fbee1ff8682762cd2f291070491fe3e476787cf.

It turns out that this change requires a couple of other changes along with it, including #880 and better overall checking of overriding of equals() methods. We want to get a release out soon, so temporarily revert this change; we will restore it after cutting the release.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c44ab8d) 87.18% compared to head (5473961) 87.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #886 +/- ## ============================================ + Coverage 87.18% 87.20% +0.01% + Complexity 1950 1947 -3 ============================================ Files 77 77 Lines 6274 6268 -6 Branches 1219 1216 -3 ============================================ - Hits 5470 5466 -4 + Misses 405 403 -2 Partials 399 399 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.