search

uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Fix bug with implicit equals() methods in interfaces #898

Closed msridhar closed 8 months ago

msridhar commented 9 months ago

Fixes #897

This fixes a regression in our handling of implicit equals() methods in interfaces when building on JDK 21. I see this as an interim fix, until we can fix NullAway to properly always assume / enforce that the parameter of equals() is @Nullable. But, I think we should fix the regression in the short term.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c1eb8ca) 86.95% compared to head (aa12d03) 86.96%.

Files Patch % Lines
...away/src/main/java/com/uber/nullaway/NullAway.java 75.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #898 +/- ## ============================================ + Coverage 86.95% 86.96% +0.01% - Complexity 1953 1956 +3 ============================================ Files 77 77 Lines 6315 6320 +5 Branches 1222 1224 +2 ============================================ + Hits 5491 5496 +5 + Misses 420 419 -1 - Partials 404 405 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.