search

uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Add foojay-resolver-convention plugin #905

Closed msridhar closed 8 months ago

msridhar commented 8 months ago

See https://github.com/gradle/foojay-toolchains. With this plugin, if relevant toolchains are not present on the local machine (e.g., for JDK 8 or JDK 21), Gradle will automatically download an appropriate distribution and place it in the local Gradle cache. This plugin is officially supported by Gradle, so I think it's safe to add. Without this plugin, new contributors may run into issues running basic commands like ./gradlew compileJava since it requires multiple JDKs to be installed in order to succeed.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (848b0b1) 86.98% compared to head (701dd3c) 86.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #905 +/- ## ========================================= Coverage 86.98% 86.98% Complexity 1959 1959 ========================================= Files 77 77 Lines 6330 6330 Branches 1223 1223 ========================================= Hits 5506 5506 Misses 420 420 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuxincs commented 8 months ago

quick question due to my unfamiliarity with these: would it mess with user's local java installations or is it project-specific and will be put in gradle's cache folder or somewhere?

msridhar commented 8 months ago

quick question due to my unfamiliarity with these: would it mess with user's local java installations or is it project-specific and will be put in gradle's cache folder or somewhere?

It will not mess with any local installations; the downloaded toolchain is placed in the Gradle cache. Also, if Gradle's toolchain auto-detection finds a local installation of the right version of the JDK, nothing gets downloaded.