uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Don't report @Nullable type argument errors for unmarked classes #958

Closed haewiful closed 4 months ago

haewiful commented 5 months ago

Thank you for contributing to NullAway!

Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.

Before pressing the "Create Pull Request" button, please provide the following:

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (9860ab2) to head (06c01c1).

Files Patch % Lines
...away/src/main/java/com/uber/nullaway/NullAway.java 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #958 +/- ## ============================================ - Coverage 85.94% 85.94% -0.01% - Complexity 2045 2047 +2 ============================================ Files 81 81 Lines 6761 6765 +4 Branches 1302 1305 +3 ============================================ + Hits 5811 5814 +3 Misses 537 537 - Partials 413 414 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msridhar commented 4 months ago

@haewiful CI is failing:

https://github.com/uber/NullAway/actions/runs/9507798037/job/26207945224?pr=958#step:6:506

You can run ./gradlew :nullaway:buildWithNullAway to reproduce. It's failing when we try to run NullAway on itself.