Closed robinst closed 3 months ago
Steps to reproduce:
LibraryModels
castToNonNullMethods
"<T>castToNonNull(T, java.lang.String)"
Expected: It works, because the Javadocs example has a comma, see: https://github.com/uber/NullAway/blob/6cec433e639f7a7eab449e742a71380d0e107692/nullaway/src/main/java/com/uber/nullaway/LibraryModels.java#L189-L190 Actual: The space doesn't make it work. Removing the space makes it work:
-"<T>castToNonNull(T, java.lang.String)" +"<T>castToNonNull(T,java.lang.String)"
The Javadocs should probably be fixed, or spaces could be removed by methodRef.
methodRef
Thanks for the report, I've put up #973 to fix the documentation.
Perfect, thank you!
Steps to reproduce:
LibraryModels
implementationcastToNonNullMethods
method and return a method ref with a signature like"<T>castToNonNull(T, java.lang.String)"
(notice the space after the comma!)Expected: It works, because the Javadocs example has a comma, see: https://github.com/uber/NullAway/blob/6cec433e639f7a7eab449e742a71380d0e107692/nullaway/src/main/java/com/uber/nullaway/LibraryModels.java#L189-L190 Actual: The space doesn't make it work. Removing the space makes it work:
The Javadocs should probably be fixed, or spaces could be removed by
methodRef
.