Closed msridhar closed 3 months ago
Attention: Patch coverage is 86.76471%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 85.94%. Comparing base (
646b7ab
) to head (50c3440
).
Files | Patch % | Lines |
---|---|---|
...va/com/uber/nullaway/ErrorProneCLIFlagsConfig.java | 86.76% | 5 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
AbstractConfig
has only had one subclass for a long time, and I don't see any future scenario in which we add more. RemovingAbstractConfig
makes adding new NullAway options easier. We push down the code fromAbstractConfig
intoErrorProneCLIFlagsConfig
and make the fields private and final instead of protected.