Closed msridhar closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.94%. Comparing base (
87f16cd
) to head (959446b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #968
The key difference is now the benchmarking job only starts when the label with the name
run-benchmarks
is added to a PR. According to the docs only those with triage access to the repository can add or remove a label. In contrast, anyone can comment on an issue, which made our previous technique for kick-starting the benchmarks unsafe. Before adding therun-benchmarks
label, a PR should be reviewed to check for malicious code.It is impossible to test this workflow without first merging it to the main branch. However, I did test it using a PR on my fork, and confirmed it could comment back the benchmark results like before:
https://github.com/msridhar/NullAway/pull/12
After merging this PR we'll also have to add some credentials to the main NullAway repo to make this work. But first we should review, land, and then see that it fails as expected without the credentials.
Compared to the earlier workflow file, beyond changing to use labeling, I updated the versions of some external GitHub actions we are using.