search

uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Bug fixes for array subtyping at returns / parameter passing #980

Closed msridhar closed 4 months ago

msridhar commented 4 months ago

In certain places we were bailing out for types without type arguments, but those bailouts are wrong now that we check array subtyping. Also, for identifiers, we now get the type from the Symbol which is more reliable.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (76115d4) to head (26b1eaf).

Files Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #980 +/- ## ========================================= Coverage 85.90% 85.90% + Complexity 2067 2066 -1 ========================================= Files 83 83 Lines 6859 6854 -5 Branches 1323 1320 -3 ========================================= - Hits 5892 5888 -4 Misses 550 550 + Partials 417 416 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.