search

uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3.01k stars 234 forks source link

fix bugs in bootstrap process #238

Closed jshencode closed 5 years ago

jshencode commented 5 years ago
  1. h2c to use http2 without TLS
  2. missing SessionID and NodeID in peer streaming requests
  3. initialize peer source
  4. strip http:// from host address in grpc call

tested node replacement operation locally with controller and 3 initial data nodes

codecov-io commented 5 years ago

Codecov Report

Merging #238 into master will increase coverage by <.01%. The diff coverage is 59.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   69.47%   69.47%   +<.01%     
==========================================
  Files         159      159              
  Lines       21197    21217      +20     
==========================================
+ Hits        14727    14741      +14     
- Misses       5345     5352       +7     
+ Partials     1125     1124       -1
Impacted Files Coverage Δ
datanode/bootstrap.go 0% <0%> (ø) :arrow_up:
datanode/datanode.go 0% <0%> (ø) :arrow_up:
utils/http.go 62.5% <0%> (ø) :arrow_up:
datanode/peer_source.go 50% <40%> (-5%) :arrow_down:
memstore/bootstrap.go 67.83% <90.9%> (+0.77%) :arrow_up:
memstore/cuckoo_index.go 91.27% <0%> (+1%) :arrow_up:
memstore/backfill_manager.go 92.07% <0%> (+4.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9af1a92...dcfc50a. Read the comment docs.