Useless field assignment in `query_handler.go`

uber / aresdb

A GPU-powered real-time analytics storage and query engine.

https://eng.uber.com/aresdb/

Apache License 2.0

3.01k stars 234 forks source link

Useless field assignment in `query_handler.go` #272

Open xiemaisi opened 5 years ago

xiemaisi commented 5 years ago

Describe the bug

It looks like this assignment to aqlRequest.Verbose is dead (the field is never read in the same function, and aqlRequest is not a pointer).

To Reproduce

I found this issue using static analysis, so I cannot provide reproduction steps. I imagine one possible outcome of this could be that this if condition never holds,

hasitpbhatt commented 4 years ago

Maybe it was done just in case someone needs to use aqlRequest.Verbose later in the same function. Not sure, though.

@shz117, can you help us out here?