search

uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3.03k stars 234 forks source link

enum case for default value #276

Closed jshencode closed 5 years ago

jshencode commented 5 years ago

  1. in single instance version, we make default value the first enum case for enum columns we should do the same in controller

  2. for debug ui we read local to translate eum, in distributed case, we should use the enum reader for translating.

codecov-io commented 5 years ago

Codecov Report

Merging #276 into master will increase coverage by <.01%. The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage    71.8%   71.81%   +<.01%     
==========================================
  Files         166      166              
  Lines       22868    22883      +15     
==========================================
+ Hits        16421    16433      +12     
- Misses       5167     5173       +6     
+ Partials     1280     1277       -3
Impacted Files Coverage Δ
utils/options.go 0% <ø> (ø) :arrow_up:
memstore/schema.go 86.66% <100%> (+0.08%) :arrow_up:
datanode/datanode.go 17.24% <100%> (+0.22%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <100%> (+0.9%) :arrow_up:
api/debug_handler.go 73.5% <63.63%> (-0.37%) :arrow_down:
subscriber/common/job/driver.go 69.85% <0%> (-0.71%) :arrow_down:
broker/query_plan_non_agg.go 86.56% <0%> (+2.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d025413...643a70a. Read the comment docs.