uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3.01k stars 234 forks source link

Suns #277

Closed lxning closed 5 years ago

lxning commented 5 years ago
  1. Update etcdConfig to support uns
  2. Update etcdConfig loading
  3. Refactor etcd heartbeat registration
  4. Only load aresdb instances from jobAssignment if sinkmode is aresDB
  5. Update GetDataValue if type is not string.
  6. Set sarama publisher manual partition for fact table
codecov-io commented 5 years ago

Codecov Report

Merging #277 into master will decrease coverage by <.01%. The diff coverage is 76.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #277      +/-   ##
=========================================
- Coverage    71.8%   71.8%   -0.01%     
=========================================
  Files         166     166              
  Lines       22868   23009     +141     
=========================================
+ Hits        16421   16521     +100     
- Misses       5167    5206      +39     
- Partials     1280    1282       +2
Impacted Files Coverage Δ
memstore/common/pinnable.go 0% <ø> (ø) :arrow_up:
subscriber/common/rules/job_config.go 68.42% <0%> (-4.53%) :arrow_down:
memstore/vectors/vector.go 0% <0%> (ø) :arrow_up:
client/schema.go 67.37% <100%> (ø) :arrow_up:
memstore/common/data_value.go 80.58% <100%> (+4.42%) :arrow_up:
subscriber/common/sink/sink.go 59.52% <100%> (-1.27%) :arrow_down:
subscriber/common/job/controller.go 39.08% <20.83%> (-2.81%) :arrow_down:
subscriber/config/service_config.go 77.35% <50%> (-4.87%) :arrow_down:
subscriber/common/sink/kafka.go 76.66% <53.33%> (-6.87%) :arrow_down:
subscriber/common/job/driver.go 66.31% <0%> (-4.26%) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d025413...f5e88b6. Read the comment docs.

lxning commented 5 years ago

could you also add the ManualPartitioner setting into the producer setting in this diff

done