search

uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

fix errors in table deletion #280

Closed jshencode closed 4 years ago

jshencode commented 4 years ago

  1. it is possible to have tables deleted in metastore when scheduled jobs are already running and trying to create new versions in metastore, in such case we should not panic and crash the server

  2. host memory manager should ignore deleted tables when reporting memory usage

codecov-io commented 4 years ago

Codecov Report

Merging #280 into master will decrease coverage by 0.14%. The diff coverage is 69.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage      72%   71.85%   -0.15%     
==========================================
  Files         166      166              
  Lines       22885    22891       +6     
==========================================
- Hits        16478    16448      -30     
- Misses       5124     5166      +42     
+ Partials     1283     1277       -6
Impacted Files Coverage Δ
memstore/host_memory_manager.go 97.17% <0%> (ø) :arrow_up:
broker/broker_schema_mutator.go 59.77% <0%> (ø) :arrow_up:
controller/mutators/etcd/enum_mutator.go 79.01% <0%> (ø) :arrow_up:
api/schema_handler.go 80.18% <100%> (ø) :arrow_up:
controller/mutators/etcd/schema_mutator.go 63.58% <50%> (ø) :arrow_up:
memstore/archiving.go 86.45% <64.28%> (-1.05%) :arrow_down:
memstore/schema.go 86.66% <66.66%> (ø) :arrow_up:
metastore/validator.go 83.62% <68%> (ø) :arrow_up:
memstore/backfill.go 74.24% <76.92%> (-0.62%) :arrow_down:
metastore/disk_metastore.go 74.41% <93.75%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 027a428...ce50b0b. Read the comment docs.