search

uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

Conn #284

Closed lxning closed 4 years ago

lxning commented 4 years ago
  1. add Close in client/connector
  2. set controller default FailureHandlerMaxRetryMinutes as 15min instead of 365days
codecov-io commented 4 years ago

Codecov Report

Merging #284 into master will increase coverage by <.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #284      +/-   ##
=========================================
+ Coverage   71.69%   71.7%   +<.01%     
=========================================
  Files         166     166              
  Lines       23079   23084       +5     
=========================================
+ Hits        16547   16552       +5     
- Misses       5239    5242       +3     
+ Partials     1293    1290       -3
Impacted Files Coverage Δ
client/connector.go 67.82% <0%> (-0.9%) :arrow_down:
subscriber/common/sink/ares_database.go 83.33% <100%> (+0.47%) :arrow_up:
subscriber/common/sink/kafka.go 76.92% <100%> (+0.25%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
memstore/cuckoo_index.go 91.27% <0%> (+1%) :arrow_up:
broker/query_plan_non_agg.go 80.26% <0%> (+1.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c222bf4...d4f9b8e. Read the comment docs.

voyager-dw commented 4 years ago

is this the cause of message lost?

lxning commented 4 years ago

is this the cause of message lost?

There was no message loss b/c the offset was not commited. Subscriber kept retrying since the failure handler retry window is 365days.