search

uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3.02k stars 234 forks source link

Fix keeplive error #290

Closed jshencode closed 5 years ago

jshencode commented 5 years ago

reusing response struct as request will leads to EOF error

codecov[bot] commented 5 years ago

Codecov Report

Merging #290 into master will decrease coverage by <.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   71.71%   71.71%   -0.01%     
==========================================
  Files         166      166              
  Lines       23096    23097       +1     
==========================================
- Hits        16564    16563       -1     
- Misses       5241     5242       +1     
- Partials     1291     1292       +1
Impacted Files Coverage Δ
memstore/bootstrap.go 68.78% <50%> (+0.08%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
memstore/cuckoo_index.go 90.26% <0%> (-1.01%) :arrow_down:
subscriber/common/job/driver.go 67.73% <0%> (+1.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ff5876...ea66a42. Read the comment docs.

jshencode commented 5 years ago

going to merge this directly. the coverage report does not make sense