uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

time duration instead of second since client side is sending duration directly #298

Closed jshencode closed 4 years ago

jshencode commented 4 years ago

this is causing server side in non purge mode essentially forever when client side crashed

codecov[bot] commented 4 years ago

Codecov Report

Merging #298 into master will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   71.74%   71.71%   -0.03%     
==========================================
  Files         166      166              
  Lines       23120    23120              
==========================================
- Hits        16587    16581       -6     
- Misses       5240     5246       +6     
  Partials     1293     1293
Impacted Files Coverage Δ
datanode/bootstrap/bootstrap_server.go 77.43% <0%> (ø) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
memstore/cuckoo_index.go 90.26% <0%> (-1.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccbccd0...48ca64e. Read the comment docs.

jshencode commented 4 years ago

coverage does not make any sense. does not add or remove and line