uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

[NLJ] implementation layout #299

Closed shz117 closed 4 years ago

shz117 commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #299 into master will increase coverage by 0.04%. The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   71.72%   71.76%   +0.04%     
==========================================
  Files         166      166              
  Lines       23137    23152      +15     
==========================================
+ Hits        16594    16615      +21     
+ Misses       5249     5243       -6     
  Partials     1294     1294
Impacted Files Coverage Δ
query/aql_context.go 88.23% <ø> (ø) :arrow_up:
query/aql_processor.go 79.88% <ø> (ø) :arrow_up:
query/time_series_aggregate.go 77.37% <ø> (ø) :arrow_up:
query/aql_batchexecutor.go 82.53% <100%> (ø) :arrow_up:
query/aql_compiler.go 74.27% <90.47%> (+0.53%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 63.58% <0%> (+1.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26f79d5...bc3920f. Read the comment docs.

voyager-dw commented 4 years ago

Let's have some discussion first