uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3.02k stars 234 forks source link

broker bug fix: 1. send rewritten query to datanode 2. return empty hll result correctly 3. resultSize is not len(result) #308

Closed jshencode closed 5 years ago

jshencode commented 5 years ago
  1. send rewritten query to data node which will rewrite enum string value to number
  2. return empty hll result correctly
  3. resultSize is not len(result)
  4. rewritten dim not passed back
codecov[bot] commented 5 years ago

Codecov Report

Merging #308 into master will decrease coverage by 0.01%. The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   71.88%   71.86%   -0.02%     
==========================================
  Files         166      166              
  Lines       23252    23291      +39     
==========================================
+ Hits        16714    16739      +25     
- Misses       5246     5261      +15     
+ Partials     1292     1291       -1
Impacted Files Coverage Δ
datanode/client/query_client.go 66.23% <0%> (-0.88%) :arrow_down:
broker/query_plan_agg.go 81.18% <100%> (+1.32%) :arrow_up:
broker/query_plan_non_agg.go 79.04% <100%> (+0.12%) :arrow_up:
broker/query_compiler.go 59.23% <71.42%> (+0.54%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
subscriber/common/job/driver.go 66.31% <0%> (-1.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56108d0...bc204e0. Read the comment docs.

voyager-dw commented 5 years ago

lgtm