uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

force time column uint32 #321

Closed lxning closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #321 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #321      +/-   ##
=========================================
+ Coverage   72.03%   72.1%   +0.06%     
=========================================
  Files         167     167              
  Lines       23591   23598       +7     
=========================================
+ Hits        16994   17015      +21     
+ Misses       5292    5278      -14     
  Partials     1305    1305
Impacted Files Coverage Δ
datanode/datanode.go 18.81% <ø> (ø) :arrow_up:
api/debug_handler.go 74.79% <ø> (ø) :arrow_up:
api/query_handler.go 73.68% <100%> (ø) :arrow_up:
memstore/list/archive_vector_party.go 66.82% <100%> (ø) :arrow_up:
api/data_handler.go 70% <100%> (ø) :arrow_up:
query/aql_processor.go 80.83% <100%> (ø) :arrow_up:
subscriber/common/message/message_parser.go 62.5% <100%> (+8.56%) :arrow_up:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
memstore/cuckoo_index.go 91.27% <0%> (+1%) :arrow_up:
subscriber/common/job/streaming_processor.go 63.69% <0%> (+2.22%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62ef6e6...0d6f452. Read the comment docs.

lxning commented 4 years ago

since we are doing this change. I think it might be better to provide more supported underlying transformation for time column. Like from string (ISO timestamp format) to uint32 seconds will be quite useful to users

Transformation needs define the mapping b/w from item in message and to column in table schema. This definition has not been supported in RTA yet.

lxning commented 4 years ago

merge with backfill support