uber / aresdb

A GPU-powered real-time analytics storage and query engine.
https://eng.uber.com/aresdb/
Apache License 2.0
3k stars 233 forks source link

WriteSyncCloser #323

Closed jshencode closed 4 years ago

jshencode commented 4 years ago

avoid syncing on every single write operation to file sync only when operation is done

codecov[bot] commented 4 years ago

Codecov Report

Merging #323 into master will decrease coverage by 0.02%. The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #323      +/-   ##
=========================================
- Coverage   72.03%     72%   -0.03%     
=========================================
  Files         167     167              
  Lines       23591   23598       +7     
=========================================
- Hits        16994   16992       -2     
- Misses       5292    5305      +13     
+ Partials     1305    1301       -4
Impacted Files Coverage Δ
utils/serialization.go 96.9% <0%> (-1.01%) :arrow_down:
redolog/file_redolog_manager.go 71.9% <0%> (-1.4%) :arrow_down:
memstore/common/vector_party_serializer.go 0% <0%> (ø) :arrow_up:
diskstore/local_diskstore.go 67.76% <100%> (+1.63%) :arrow_up:
memstore/bootstrap.go 68.42% <33.33%> (-0.37%) :arrow_down:
controller/mutators/etcd/schema_mutator.go 61.84% <0%> (-1.74%) :arrow_down:
subscriber/common/job/driver.go 66.31% <0%> (-1.42%) :arrow_down:
memstore/cuckoo_index.go 91.27% <0%> (+1%) :arrow_up:
cluster/topology/healthtracking_dynamic.go 60% <0%> (+3.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62ef6e6...4bc3816. Read the comment docs.