search

uber / bayesmark

Benchmark framework to easily compare Bayesian optimization methods on real machine learning tasks
Apache License 2.0
139 stars 33 forks source link

Change >= version pins to ~= #5

Closed akx closed 4 years ago

akx commented 4 years ago

= pins may have Pip pull in a wildly incompatible version of a requirement (upgrading major versions). ~= will use a compatible version (i.e. e.g. the same major.minor but allowing patch upgrades).

Originally spotted by @juhakiili re pip installing pathvalidate >= 2.0, which is incompatible.

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

rdturnermtl commented 4 years ago

This PR is no longer necessary since we have fixed the incompatibility with the newer version of pathvalidate. Using >= seems to work fine for now.