uber / cadence-java-client

Java framework for Cadence Workflow Service
https://cadenceworkflow.io
Other
142 stars 106 forks source link

Addition of logs to scanWorkflows in shadower #917

Closed abhishekj720 closed 2 months ago

abhishekj720 commented 2 months ago

What changed? Added logs to scanWorflow methods

Why?

How did you test it? Just adding logs. Will be adding the tests in later diffs.

Potential risks N/A, as these are just few logs.

agautam478 commented 2 months ago

LGTM. Approving because we urgently need these logs to debug the issues with internal shadower.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 2440

Details


Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadImpl.java 1 77.32%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 2433: 0.08%
Covered Lines: 12098
Relevant Lines: 19503

💛 - Coveralls
abhishekj720 commented 2 months ago

Some build issue.