search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.18k stars 790 forks source link

GOOS=linux GOARCH=amd64 make bins fails #1531

Closed aned closed 5 years ago

aned commented 5 years ago 
 GOOS=linux GOARCH=amd64 make bins

go get './vendor/go.uber.org/thriftrw'
go get './vendor/go.uber.org/yarpc/encoding/thrift/thriftrw-plugin-yarpc'
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/cadence.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/health.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/history.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/matching.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/replicator.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/indexer.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/shared.thrift
/Users/anedoshe/go/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/admin.thrift
./install-dep.sh
Warning: dep 0.5.1 is already installed and up-to-date
To reinstall 0.5.1, run `brew reinstall dep`
dep ensure
Running linter
./common/persistence/persistence-tests/visibilityPersistenceTest.go:120:1: comment on exported method VisibilityPersistenceSuite.TestBasicVisibility_TimeSkew should be of the form "TestBasicVisibility_TimeSkew ..."
./common/persistence/persistence-tests/visibilityPersistenceTest.go:121:38: don't use underscores in Go names; method TestBasicVisibility_TimeSkew should be TestBasicVisibilityTimeSkew
./service/history/stateBuilder.go:64:2: exported const ErrMessageNewRunHistorySizeZero should have comment (or a comment on this block) or be unexported
go run ./cmd/tools/copyright/licensegen.go --verifyOnly
fork/exec /var/folders/c4/40nc2xbd12s724b7729_6twh000vd1/T/go-build860520299/b001/exe/licensegen: exec format error
make: *** [copyright] Error 1
pgohite commented 5 years ago

I think this fails as go run ./cmd/tools/copyright/licensegen.go executes on compiling host machine and we changed GOOS for cross compilation, licensegen.go is cross compiled but executed on host os.