Closed 3vilhamster closed 1 month ago
codecov[bot]
commented
1 month ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.33%. Comparing base (
fb4bfce) to head (fe2b7a8). Report is 2 commits behind head on master.
coveralls
commented
1 month ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 88.06% | ||
| common/peerprovider/ringpopprovider/config.go | 2 | 81.58% | ||
| common/persistence/execution_manager.go | 2 | 86.43% | ||
| service/matching/tasklist/task_list_manager.go | 2 | 76.09% | ||
| common/persistence/sql/sqlplugin/mysql/task.go | 2 | 73.68% | ||
| service/history/task/transfer_active_task_executor.go | 2 | 72.72% | ||
| common/persistence/sql/sqlplugin/mysql/db.go | 2 | 79.49% | ||
| common/task/fifo_task_scheduler.go | 3 | 84.54% | ||
| service/history/task/fetcher.go | 3 | 85.57% | ||
| service/frontend/api/handler.go | 4 | 62.26% | ||
| <!-- | Total: | 51 | --> |
| Totals | |
|---|---|
| Change from base Build 018fa464-40c9-4742-b88d-967555b43b81: | -0.002% |
| Covered Lines: | 102170 |
| Relevant Lines: | 147418 |
What changed? I've added support for wrapped errors for transport level.
Why? This will allow us to return wrapped errors in services and not think about transport-level conversions.
Alternatively, we could introduce error methods To/FromProto and To/FromThrift, so instead of type assertion, we just return the result, I've tried it, but it complicates the error code significantly, while the generic solution is easier to understand.
How did you test it? Unti tests
Potential risks
Release notes
Documentation Changes