uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Added tests for CompleteTasks #6051

Closed jakobht closed 1 month ago

jakobht commented 1 month ago

What changed?

Why? Increase coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018faa93-0656-487c-af1a-f68af9c95d35

Details


Files with Coverage Reduction New Missed Lines %
service/matching/tasklist/db.go 2 73.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/history/task/transfer_standby_task_executor.go 4 87.24%
service/matching/tasklist/matcher.go 4 88.66%
service/history/task/fetcher.go 4 86.08%
common/task/fifo_task_scheduler.go 7 82.47%
service/matching/tasklist/task_reader.go 11 75.07%
<!-- Total: 61 -->
Totals Coverage Status
Change from base Build 018faa62-bb7e-4a04-89d5-ced9d0d49d30: 0.008%
Covered Lines: 102409
Relevant Lines: 147418

💛 - Coveralls
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.87%. Comparing base (edc5880) to head (dfe581c).

Additional details and impacted files [see 7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6051/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6051?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6051?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [edc5880...dfe581c](https://app.codecov.io/gh/uber/cadence/pull/6051?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).