search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 791 forks source link

Adding more tests to shard/context.go #6052

Closed dkrotx closed 3 months ago

dkrotx commented 4 months ago

Tests for couple of more functions in context.go

code-coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.54%. Comparing base (fb4bfce) to head (2d60232). Report is 1 commits behind head on master.

Additional details and impacted files [see 8 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6052/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6052?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6052?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [fb4bfce...2d60232](https://app.codecov.io/gh/uber/cadence/pull/6052?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 018fa61a-80af-43aa-bd2e-7170bb094d50

Details

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.65%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/frontend/api/handler.go 2 62.2%
service/history/replication/task_processor.go 2 81.25%
service/matching/tasklist/matcher.go 2 88.66%
common/log/tag/tags.go 3 50.46%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/persistence/nosql/nosql_task_store.go 5 63.97%
service/frontend/wrappers/metered/metered.go 9 63.18%
<!-- Total: 141 -->
Totals Coverage Status
Change from base Build 018fa5a0-da9b-4f76-9263-3511c2f681f9: -0.04%
Covered Lines: 102126
Relevant Lines: 147336
💛 - Coveralls