uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Add tests for history decision task handler #6053

Closed ketsiambaku closed 1 month ago

ketsiambaku commented 1 month ago

What changed? The following tests added in service/history/decision: TestHandleDecisionStartTimer TestHandleDecisionCompleteWorkflow TestHandleDecisionFailWorkflow

Why? improve code coverage in the package

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.57%. Comparing base (fb4bfce) to head (1830694). Report is 2 commits behind head on master.

Additional details and impacted files [see 10 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6053/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6053?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6053?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [fb4bfce...1830694](https://app.codecov.io/gh/uber/cadence/pull/6053?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fa6b3-4bdc-4962-b180-08089f1eee69

Details


Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.21%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/matching/tasklist/task_writer.go 2 82.63%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/timer_active_task_executor.go 3 79.33%
common/persistence/nosql/nosql_task_store.go 5 63.97%
service/history/execution/cache.go 6 74.61%
<!-- Total: 117 -->
Totals Coverage Status
Change from base Build 018fa5a0-da9b-4f76-9263-3511c2f681f9: -0.008%
Covered Lines: 102165
Relevant Lines: 147336

💛 - Coveralls