uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Add tests for Put/GetReplicationTasksDLQ #6057

Closed 3vilhamster closed 1 month ago

3vilhamster commented 1 month ago

What changed? Added tests for PutReplicationTaskToDLQ and GetReplicationTasksFromDLQ

Why? Improving test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.84%. Comparing base (96c47bc) to head (02be6b3). Report is 3 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6057?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/persistence/execution\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6057?src=pr&el=tree&filepath=common%2Fpersistence%2Fexecution_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2V4ZWN1dGlvbl9tYW5hZ2VyLmdv) | `76.02% <100.00%> (+3.79%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6057/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6057?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6057?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [96c47bc...02be6b3](https://app.codecov.io/gh/uber/cadence/pull/6057?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018faa28-3da5-4939-b8e4-1fc68b934b9c

Details


Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.21%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/persistence/execution_manager.go 2 86.67%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/task/fifo_task_scheduler.go 2 87.63%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.78%
common/persistence/nosql/utils.go 2 60.0%
common/persistence/statsComputer.go 2 97.14%
<!-- Total: 94 -->
Totals Coverage Status
Change from base Build 018faa0a-b974-48e9-b632-cc3f5a4155ca: -0.02%
Covered Lines: 102353
Relevant Lines: 147418

💛 - Coveralls