uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

[code-coverage] Add tests for history decision task handler #6060

Closed ketsiambaku closed 1 month ago

ketsiambaku commented 1 month ago

What changed? Introduced the following tests in service/history/decision:

Why? improve code coverage in the package

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.99%. Comparing base (edc5880) to head (22bfd07). Report is 3 commits behind head on master.

Additional details and impacted files [see 11 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6060/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6060?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6060?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [edc5880...22bfd07](https://app.codecov.io/gh/uber/cadence/pull/6060?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fabc6-df68-4d1a-b108-9517f6a6deb1

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.72%
service/matching/tasklist/matcher.go 2 88.66%
service/history/task/fetcher.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/worker/scanner/executor/runq.go 3 85.48%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/frontend/api/handler.go 6 62.2%
<!-- Total: 116 -->
Totals Coverage Status
Change from base Build 018faadd-0f68-4f46-a937-a0c09b154ebd: 0.02%
Covered Lines: 102455
Relevant Lines: 147418

💛 - Coveralls