Groxx
commented
1 month ago ❯ GOTOOLCHAIN=auto make
Makefile:46: warning: your Go toolchain is explicitly set to GOTOOLCHAIN=auto, ignoring go.work version go1.22.3...which seems pretty good.
CI has a bunch of lines like
Makefile:46: warning: your Go toolchain is explicitly set to GOTOOLCHAIN=local, ignoring go.work version go1.22.3...which could be handled more quietly by querying go version... but that'd potentially force a download before it responds, which could cause a big surprising lag if it happened on a dev's machine.
but maybe. or maybe there's a different, better option somewhere. not sure at the moment.
codecov[bot]
coveralls
Go 1.21 brought us "toolchains": We can now describe the version we want, and the Go CLI will automagically download, install, and use that version, with no extra effort. It should give us a MUCH more reliable way to ensure identical builds and formats and whatnot, and all us devs will auto-switch as we jump between git SHAs.
So let's use that!
This does a few things:
goversion to work on Cadence.go 1.20lines. just development in this workspace.go.worktoolchain (if there's ago.workfile, toolchains in individualgo.modfiles are ignored)go.modfiles too if it helps, it just won't have any effect on CLIgouse so it may be misleading.GOTOOLCHAIN=...inside the Makefile, so ALL makefile-driven builds by everyone use exactly the same version (you can override this with an explicitGOTOOLCHAIN)For future upgrades, upgrading the toolchain should be very simple:
go.workto a new toolchain versionmake lintormake pror CI will tell you to change the Dockerfiles / other locations, if you don'tgit grep -F 1.22.3to find and update those first.And temporarily trying a different version to check a bug / performance / try the new version is:
GOTOOLCHAIN=go1.23.4 make whateverand it'll do exactly that (except for the version check inmake lint)make cleanas well, to rebuild tools if that's relevant.build/go1.23.4/etcfolders, if we want that.