uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

We now do not log on recent shard closed errors from the getWorkflowExecutionWithRetry function #6068

Closed jakobht closed 1 month ago

jakobht commented 1 month ago

What changed? We now do not log on recent shard closed errors from the getWorkflowExecutionWithRetry function, for other errors we still log all

Why? Shard closed error are expected for a short time after a shard has been stolen, so there is no reason to do error logs on it for the first short while.

How did you test it? Unit tests

Potential risks Minimal only touches logging logic

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.15%. Comparing base (2f08de5) to head (18ad578). Report is 6 commits behind head on master.

:exclamation: Current head 18ad578 differs from pull request most recent head 6ee642c

Please upload reports for the commit 6ee642c to get more accurate results.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6068?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/history/execution/context.go](https://app.codecov.io/gh/uber/cadence/pull/6068?src=pr&el=tree&filepath=service%2Fhistory%2Fexecution%2Fcontext.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9oaXN0b3J5L2V4ZWN1dGlvbi9jb250ZXh0Lmdv) | `84.86% <100.00%> (+0.04%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6068/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6068?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6068?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [2f08de5...6ee642c](https://app.codecov.io/gh/uber/cadence/pull/6068?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).