search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

[code-coverage] Add tests for mutable_state_manager.go #6070

Closed ketsiambaku closed 2 weeks ago

ketsiambaku commented 1 month ago

What changed? Added the following tests:

Why? improve code coverage in mutable_state_manager.go

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.29%. Comparing base (c6a145d) to head (ec50a72). Report is 42 commits behind head on master.

Additional details and impacted files [see 9 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6070/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6070?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6070?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [c6a145d...ec50a72](https://app.codecov.io/gh/uber/cadence/pull/6070?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fdb29-8918-4d73-a041-a61fdf28670e

Details

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/persistence/execution_manager.go 2 90.46%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/replication/task_processor.go 2 81.25%
common/persistence/statsComputer.go 2 98.57%
service/history/task/task.go 3 84.81%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/task/fetcher.go 4 85.05%
<!-- Total: 93 -->
Totals Coverage Status
Change from base Build 018fd17e-a401-4eba-8372-591d1e581574: -0.04%
Covered Lines: 103031
Relevant Lines: 147930
💛 - Coveralls