uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Refactor pinot visibility and add migration config #6072

Closed neil-xie closed 1 week ago

neil-xie commented 1 month ago

What changed?

Why? Pinot migration

How did you test it? Unit test

Potential risks

Release notes

Documentation Changes

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 01903bc5-0d53-4b5e-bab6-5fd7c389bc9b

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/service.go 11 13 84.62%
common/persistence/client/factory.go 21 24 87.5%
host/testcluster.go 0 5 0.0%
cmd/server/cadence/server.go 0 33 0.0%
<!-- Total: 67 110 60.91% -->
Files with Coverage Reduction New Missed Lines %
host/testcluster.go 1 68.2%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 84.54%
service/history/task/transfer_standby_task_executor.go 4 86.33%
service/history/task/fetcher.go 4 86.08%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 01902d04-8e9b-4f7d-944e-581dc33c96e7: 0.05%
Covered Lines: 106628
Relevant Lines: 149166

💛 - Coveralls
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (91c09ef) to head (393eba8). Report is 2 commits behind head on master.

:exclamation: Current head 393eba8 differs from pull request most recent head 4fb0a70

Please upload reports for the commit 4fb0a70 to get more accurate results.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6072?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/persistence/visibility\_dual\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6072?src=pr&el=tree&filepath=common%2Fpersistence%2Fvisibility_dual_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Zpc2liaWxpdHlfZHVhbF9tYW5hZ2VyLmdv) | `100.00% <100.00%> (ø)` | | | [common/persistence/visibility\_triple\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6072?src=pr&el=tree&filepath=common%2Fpersistence%2Fvisibility_triple_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Zpc2liaWxpdHlfdHJpcGxlX21hbmFnZXIuZ28=) | `97.80% <100.00%> (ø)` | | | [common/persistence/client/factory.go](https://app.codecov.io/gh/uber/cadence/pull/6072?src=pr&el=tree&filepath=common%2Fpersistence%2Fclient%2Ffactory.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2NsaWVudC9mYWN0b3J5Lmdv) | `51.26% <4.76%> (-1.92%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6072/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6072?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6072?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [91c09ef...4fb0a70](https://app.codecov.io/gh/uber/cadence/pull/6072?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).