uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Move err check before log message #6073

Closed sankari165 closed 1 month ago

sankari165 commented 1 month ago

What changed? Err check moved before log message

Why? Addressing a nit comment from previous pull request 6065

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.18%. Comparing base (dd54cd0) to head (2efccf5). Report is 4 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6073?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/frontend/api/handler.go](https://app.codecov.io/gh/uber/cadence/pull/6073?src=pr&el=tree&filepath=service%2Ffrontend%2Fapi%2Fhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9mcm9udGVuZC9hcGkvaGFuZGxlci5nbw==) | `40.10% <100.00%> (+0.50%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6073/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6073?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6073?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [f3ef924...2efccf5](https://app.codecov.io/gh/uber/cadence/pull/6073?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fcefc-1f11-4a84-8d3a-59e490051363

Details


Files with Coverage Reduction New Missed Lines %
service/frontend/api/handler.go 1 62.44%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/execution_manager.go 2 87.41%
common/task/fifo_task_scheduler.go 2 83.51%
service/history/task/transfer_active_task_executor.go 2 72.79%
common/util.go 2 91.78%
service/matching/tasklist/task_writer.go 2 82.63%
service/matching/tasklist/task_reader.go 2 77.45%
common/persistence/historyManager.go 2 66.67%
common/persistence/nosql/nosql_task_store.go 3 85.52%
<!-- Total: 70 -->
Totals Coverage Status
Change from base Build 018fcd8a-6d92-406f-9861-fe59d0f7e5a7: -0.03%
Covered Lines: 102925
Relevant Lines: 147867

💛 - Coveralls