uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Test CreateWorkflowExecution in execution manager #6075

Closed 3vilhamster closed 1 month ago

3vilhamster commented 1 month ago

What changed? Added tests for CreateWorkflowExecution.

Why? Improving test coverage.

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.22%. Comparing base (eaa93b1) to head (58f750f).

Additional details and impacted files [see 7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6075/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6075?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6075?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [eaa93b1...58f750f](https://app.codecov.io/gh/uber/cadence/pull/6075?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fcf10-f72d-40cf-966e-05533b138082

Details


Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.94%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/execution_manager.go 2 90.46%
service/matching/tasklist/task_list_manager.go 2 76.09%
common/util.go 2 91.78%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 2 98.57%
common/persistence/historyManager.go 2 66.67%
common/task/fifo_task_scheduler.go 3 84.54%
<!-- Total: 63 -->
Totals Coverage Status
Change from base Build 018fcea8-93ea-4c40-a2e6-0128d36f1a8b: -0.01%
Covered Lines: 102979
Relevant Lines: 147868

💛 - Coveralls