search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Remove redundant parameter from CreateTasks flow #6077

Closed Shaddoll closed 1 month ago

Shaddoll commented 1 month ago

What changed? Remove redundant parameter from CreateTasks flow

Why? persistence.TaskInfo has workflowID and runID fields, which makes Execution parameter redundant.

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 68.22%. Comparing base (dd54cd0) to head (d1869a3). Report is 4 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6077?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/persistence/data\_manager\_interfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=common%2Fpersistence%2Fdata_manager_interfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFfbWFuYWdlcl9pbnRlcmZhY2VzLmdv) | `95.50% <ø> (ø)` | | | [common/persistence/data\_store\_interfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=common%2Fpersistence%2Fdata_store_interfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFfc3RvcmVfaW50ZXJmYWNlcy5nbw==) | `100.00% <ø> (ø)` | | | [service/matching/handler/engine.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=service%2Fmatching%2Fhandler%2Fengine.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy9oYW5kbGVyL2VuZ2luZS5nbw==) | `56.47% <ø> (-0.14%)` | :arrow_down: | | [service/matching/tasklist/task\_writer.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_writer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX3dyaXRlci5nbw==) | `77.44% <100.00%> (-0.34%)` | :arrow_down: | | [service/matching/tasklist/task\_list\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_list_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2xpc3RfbWFuYWdlci5nbw==) | `63.70% <50.00%> (ø)` | | | [service/matching/tasklist/task\_reader.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_reader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX3JlYWRlci5nbw==) | `73.80% <0.00%> (+0.92%)` | :arrow_up: | | [common/persistence/nosql/nosql\_task\_store.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=common%2Fpersistence%2Fnosql%2Fnosql_task_store.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL25vc3FsL25vc3FsX3Rhc2tfc3RvcmUuZ28=) | `71.06% <0.00%> (ø)` | | | [common/persistence/taskManager.go](https://app.codecov.io/gh/uber/cadence/pull/6077?src=pr&el=tree&filepath=common%2Fpersistence%2FtaskManager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Rhc2tNYW5hZ2VyLmdv) | `0.00% <0.00%> (ø)` | | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6077/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6077?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6077?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [dd54cd0...d1869a3](https://app.codecov.io/gh/uber/cadence/pull/6077?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fcfdb-0ea2-4e72-985c-12357d6a7098

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/matching/tasklist/task_list_manager.go 1 2 50.0%
service/matching/tasklist/task_reader.go 0 1 0.0%
common/persistence/persistence-tests/persistenceTestBase.go 0 2 0.0%
<!-- Total: 10 14 71.43% -->
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.33%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 80.41%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/visibility_single_manager.go 2 99.33%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/queue/timer_queue_processor_base.go 3 77.87%
common/persistence/wrappers/errorinjectors/utils.go 3 93.7%
<!-- Total: 1231 -->
Totals Coverage Status
Change from base Build 018fcf32-23d9-4d7d-a579-94202b6c6918: -0.03%
Covered Lines: 102829
Relevant Lines: 147693
💛 - Coveralls