search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Improve TestConcurrentAddAndPoll* tests #6079

Closed Shaddoll closed 1 month ago

Shaddoll commented 1 month ago

What changed? Improve TestConcurrentAddAndPoll* tests

Why? The tests are flaky because the ACKed tasks are not deleted from testTaskManager.

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.22%. Comparing base (eb076b2) to head (e9cc513).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6079?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/matching/tasklist/task\_gc.go](https://app.codecov.io/gh/uber/cadence/pull/6079?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_gc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2djLmdv) | `86.66% <100.00%> (ø)` | | | [service/matching/tasklist/task\_list\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6079?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_list_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2xpc3RfbWFuYWdlci5nbw==) | `63.70% <ø> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6079/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6079?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6079?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [eb076b2...e9cc513](https://app.codecov.io/gh/uber/cadence/pull/6079?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).