search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Fix DrainBacklogNoPollersIsolationGroup tests #6080

Closed Shaddoll closed 4 weeks ago

Shaddoll commented 1 month ago

What changed? Fix DrainBacklogNoPollersIsolationGroup tests

Why? The tests are flaky because we're not using the same timeSource across different components, and this makes some tasks expire and the tests never end.

How did you test it? existing tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.22%. Comparing base (c6a145d) to head (8efefd1).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6080?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/matching/tasklist/task\_list\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6080?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_list_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2xpc3RfbWFuYWdlci5nbw==) | `63.70% <100.00%> (ø)` | | | [service/matching/tasklist/task\_reader.go](https://app.codecov.io/gh/uber/cadence/pull/6080?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_reader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX3JlYWRlci5nbw==) | `73.80% <100.00%> (+0.68%)` | :arrow_up: | | [common/cache/lru.go](https://app.codecov.io/gh/uber/cadence/pull/6080?src=pr&el=tree&filepath=common%2Fcache%2Flru.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL2NhY2hlL2xydS5nbw==) | `84.97% <80.00%> (+0.26%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6080/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6080?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6080?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [c6a145d...8efefd1](https://app.codecov.io/gh/uber/cadence/pull/6080?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 018fd4cd-8372-4140-b2cf-697a6f7bac87

Details

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/execution_manager.go 2 90.46%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/replication/task_processor.go 2 81.25%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 2 98.57%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
<!-- Total: 59 -->
Totals Coverage Status
Change from base Build 018fd17e-a401-4eba-8372-591d1e581574: -0.03%
Covered Lines: 103050
Relevant Lines: 147937
💛 - Coveralls