Change permission of DescribeCluster to Read

jiaxuyang commented 1 month ago

What changed?

Add DescribeCluster permission setting in gowrap template file of frontend server access control decorator.
Run make go-generate to modify admin_generated.go

Why?

To enable users with read level access to use cadence web. As addressed in this issue.
DescribeCluster is a read operation semantically.

How did you test it? Add unit test.

Potential risks

Release notes

Documentation Changes

CLAassistant commented 1 month ago

All committers have signed the CLA.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.97%. Comparing base (e03809a) to head (b6053de). Report is 47 commits behind head on master.

Additional details and impacted files

[see 49 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6081/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6081?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6081?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [e03809a...b6053de](https://app.codecov.io/gh/uber/cadence/pull/6081?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).

Groxx commented 3 weeks ago

missing a make fmt apparently:

--- a/service/frontend/wrappers/accesscontrolled/access_controlled_test.go
+++ b/service/frontend/wrappers/accesscontrolled/access_controlled_test.go
@@ -25,8 +25,6 @@ package accesscontrolled
 import (
    "context"
    "errors"
-   "github.com/uber/cadence/common/types"
-   "github.com/uber/cadence/service/frontend/admin"
    "testing"
    "github.com/golang/mock/gomock"
@@ -35,6 +33,8 @@ import (
    "github.com/uber/cadence/common/authorization"
    "github.com/uber/cadence/common/metrics"
    "github.com/uber/cadence/common/metrics/mocks"
+   "github.com/uber/cadence/common/types"
+   "github.com/uber/cadence/service/frontend/admin"
 )
 func TestIsAuthorized(t *testing.T) {

or for a (much slower) more complete process, try make pr. that should definitely match what CI produces.

jiaxuyang commented 3 weeks ago

@Groxx @taylanisikdemir Modifications have been committed, please review it again. Thanks. Changes:

run make pr to format access_controlled_test.go

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018feb7f-b68d-44ce-952b-543c65230059

Details

0 of 0 changed or added relevant lines in 0 files are covered.
32 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.02%) to 69.68%

Files with Coverage Reduction	New Missed Lines	%
common/task/weighted_round_robin_task_scheduler.go	2	89.05%
common/task/fifo_task_scheduler.go	2	85.57%
service/history/execution/mutable_state_util.go	2	78.52%
service/matching/tasklist/matcher.go	2	88.66%
service/history/task/transfer_standby_task_executor.go	3	87.14%
service/history/task/task.go	3	84.81%
service/history/queue/timer_queue_processor_base.go	3	77.87%
common/types/history.go	4	45.35%
service/history/engine/engineimpl/record_activity_task_started.go	5	68.87%
service/history/execution/cache.go	6	74.61%
<!--	Total:	32	-->

Totals
Change from base Build 018fdb42-97b4-456b-8043-44705c1f0950:	0.02%
Covered Lines:	103078
Relevant Lines:	147930

uber / cadence