search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Improve matching SyncMatch tests #6084

Closed Shaddoll closed 4 weeks ago

Shaddoll commented 4 weeks ago

What changed?

Why? Make the tests more stable

How did you test it? ran the tests locally 500 times

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.29%. Comparing base (1463dc5) to head (45346ca). Report is 1 commits behind head on master.

Additional details and impacted files [see 9 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6084/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6084?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6084?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [1463dc5...45346ca](https://app.codecov.io/gh/uber/cadence/pull/6084?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 018fdfe7-f728-452e-ae9b-c16a1e7d3cf1

Details

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.35%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
common/persistence/nosql/nosql_task_store.go 3 85.52%
service/history/task/timer_standby_task_executor.go 3 85.63%
service/history/task/transfer_active_task_executor.go 3 72.79%
<!-- Total: 49 -->
Totals Coverage Status
Change from base Build 018fdfdd-be97-4b61-94e9-35bf8e87bec1: -0.003%
Covered Lines: 103104
Relevant Lines: 147936
💛 - Coveralls