uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Add tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go #6085

Closed fimanishi closed 4 weeks ago

fimanishi commented 4 weeks ago

Add tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

What changed? tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

Why? improve unit test coverage

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.53%. Comparing base (f0f7efd) to head (ecea749). Report is 7 commits behind head on master.

Additional details and impacted files [see 9 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6085/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6085?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6085?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [f0f7efd...ecea749](https://app.codecov.io/gh/uber/cadence/pull/6085?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 018fe06a-bbb0-4e5a-b0a6-3987fbe463a9

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/shard/context.go 2 68.99%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.79%
common/util.go 2 91.78%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/history/handler/handler.go 3 96.2%
<!-- Total: 172 -->
Totals Coverage Status
Change from base Build 018fe051-df14-4702-b515-0388c6db07f3: -0.1%
Covered Lines: 103092
Relevant Lines: 147936

💛 - Coveralls