search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Write tests for shard context #6087

Closed taylanisikdemir closed 4 weeks ago

taylanisikdemir commented 4 weeks ago

What changed? Wrote tests for some part of history/shard/context.go

Why? Improve coverage

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (ab0d875) to head (bd5eca7).

:exclamation: Current head bd5eca7 differs from pull request most recent head ad3e37a

Please upload reports for the commit ad3e37a to get more accurate results.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6087?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/history/shard/test\_context.go](https://app.codecov.io/gh/uber/cadence/pull/6087?src=pr&el=tree&filepath=service%2Fhistory%2Fshard%2Ftest_context.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9oaXN0b3J5L3NoYXJkL3Rlc3RfY29udGV4dC5nbw==) | `0.00% <0.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6087/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6087?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6087?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [ab0d875...ad3e37a](https://app.codecov.io/gh/uber/cadence/pull/6087?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 018fe4bc-3b62-4bdb-b2eb-3f37bf730fab

Details

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/matching/tasklist/db.go 2 73.23%
common/task/fifo_task_scheduler.go 2 80.41%
common/membership/hashring.go 2 84.69%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/types/history.go 4 45.35%
service/history/engine/engineimpl/record_activity_task_started.go 4 68.87%
service/frontend/api/handler.go 4 65.45%
<!-- Total: 46 -->
Totals Coverage Status
Change from base Build 018fe451-cd64-44f5-8cb8-8b9c6b71f4ba: 0.02%
Covered Lines: 104585
Relevant Lines: 148950
💛 - Coveralls