Closed bowenxia closed 4 weeks ago
Attention: Patch coverage is 2.32558%
with 42 lines
in your changes missing coverage. Please review.
Project coverage is 68.52%. Comparing base (
f0f7efd
) to head (f092d74
). Report is 6 commits behind head on master.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
common/task/weighted_round_robin_task_scheduler.go | 1 | 89.05% | ||
service/history/task/transfer_standby_task_executor.go | 2 | 87.14% | ||
common/persistence/sql/sqlplugin/mysql/task.go | 2 | 73.68% | ||
service/frontend/api/handler.go | 2 | 62.56% | ||
service/history/task/transfer_active_task_executor.go | 2 | 72.79% | ||
common/util.go | 2 | 91.78% | ||
common/persistence/sql/sqlplugin/mysql/db.go | 2 | 79.49% | ||
common/task/fifo_task_scheduler.go | 3 | 84.54% | ||
common/archiver/filestore/historyArchiver.go | 4 | 80.95% | ||
service/matching/tasklist/task_list_manager.go | 4 | 76.09% | ||
<!-- | Total: | 171 | --> |
Totals | |
---|---|
Change from base Build 018fe051-df14-4702-b515-0388c6db07f3: | -0.1% |
Covered Lines: | 103093 |
Relevant Lines: | 147942 |
What changed? Refactored methods in applyEvent to be functions, and make them as historyReplicator parameters
Why? Easier to do unit test
How did you test it?
Potential risks
Release notes
Documentation Changes