Closed Groxx closed 4 weeks ago
Difftastic makes this quite easy to check by hand:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.97%. Comparing base (
84ab621
) to head (87142e1
).
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
service/matching/tasklist/db.go | 2 | 73.23% | ||
common/peerprovider/ringpopprovider/config.go | 2 | 81.58% | ||
common/task/fifo_task_scheduler.go | 2 | 87.63% | ||
common/persistence/sql/sqlplugin/mysql/task.go | 2 | 73.68% | ||
service/history/task/transfer_active_task_executor.go | 2 | 72.79% | ||
common/persistence/sql/sqlplugin/mysql/db.go | 2 | 79.49% | ||
common/log/tag/tags.go | 3 | 50.46% | ||
service/history/handler/handler.go | 3 | 96.2% | ||
common/persistence/statsComputer.go | 3 | 98.21% | ||
service/frontend/api/handler.go | 4 | 62.5% | ||
<!-- | Total: | 88 | --> |
Totals | |
---|---|
Change from base Build 018fe051-df14-4702-b515-0388c6db07f3: | 0.3% |
Covered Lines: | 104369 |
Relevant Lines: | 148939 |
Pretty simple change: these closures don't actually buy us anything, but they do make coverage more annoying to gather because we don't call the closure. So just get rid of the closures. Shorter and free coverage.