Closed jakobht closed 4 weeks ago
codecov[bot]
commented
4 weeks ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.98%. Comparing base (
233626d) to head (3c87e0b). Report is 18 commits behind head on master.:exclamation: Current head 3c87e0b differs from pull request most recent head cd77fe7
Please upload reports for the commit cd77fe7 to get more accurate results.
coveralls
commented
4 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 88.56% | ||
| common/task/fifo_task_scheduler.go | 2 | 83.51% | ||
| common/persistence/taskManager.go | 2 | 74.49% | ||
| service/history/task/transfer_active_task_executor.go | 2 | 72.77% | ||
| common/persistence/visibility_single_manager.go | 2 | 99.33% | ||
| common/membership/hashring.go | 2 | 84.69% | ||
| service/matching/poller/history.go | 3 | 74.0% | ||
| service/history/queue/timer_queue_processor_base.go | 3 | 77.87% | ||
| common/persistence/wrappers/errorinjectors/utils.go | 3 | 93.7% | ||
| service/matching/tasklist/task_gc.go | 3 | 92.11% | ||
| <!-- | Total: | 1932 | --> |
| Totals | |
|---|---|
| Change from base Build 018fe0d5-41bf-4bbb-a373-d503fd5baf3b: | -0.4% |
| Covered Lines: | 102858 |
| Relevant Lines: | 147702 |
What changed? We now only log "Failed to signal external workflow execution" for unexpected errors. Expected errors are defined as transient errors, not exists errors and "workflow execution already completed" errors.
Why? We have a lot of "Failed to signal extermal workflow execution" error logs in server with the error being "workflow execution already completed".
This is an expected state so we should not log errors for this. Additionally we add transient errors and not exists errors to the things we should not log errors for, as they are expected in the normal operation of the system.
How did you test it? Unit tests
Potential risks
Release notes
Documentation Changes