Closed jakobht closed 3 weeks ago
codecov[bot]
commented
4 weeks ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.76%. Comparing base (
233626d) to head (4fc11b6). Report is 60 commits behind head on master.:exclamation: Current head 4fc11b6 differs from pull request most recent head 3890503
Please upload reports for the commit 3890503 to get more accurate results.
coveralls
commented
4 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 88.06% | ||
| common/task/fifo_task_scheduler.go | 2 | 87.63% | ||
| common/persistence/taskManager.go | 2 | 74.49% | ||
| common/persistence/visibility_single_manager.go | 2 | 99.33% | ||
| service/matching/tasklist/matcher.go | 2 | 89.35% | ||
| common/persistence/historyManager.go | 2 | 66.67% | ||
| service/history/handler/handler.go | 3 | 96.2% | ||
| service/matching/poller/history.go | 3 | 74.0% | ||
| service/history/queue/timer_queue_processor_base.go | 3 | 77.87% | ||
| common/persistence/wrappers/errorinjectors/utils.go | 3 | 93.7% | ||
| <!-- | Total: | 1930 | --> |
| Totals | |
|---|---|
| Change from base Build 018fe0d5-41bf-4bbb-a373-d503fd5baf3b: | -0.4% |
| Covered Lines: | 102891 |
| Relevant Lines: | 147698 |
This enables us to fail fast
What changed? Changed the lint script so the fast tests are run first
Why? go-generate takes up to 5 minutes and there is no reason to wait for this if the linter is failing. This should increase developer velocity by failing the lint check faster
How did you test it?
Potential risks
Release notes
Documentation Changes