search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.97k stars 773 forks source link

Tests for the stray lines needing coverage. #6098

Closed agautam478 closed 4 weeks ago

agautam478 commented 4 weeks ago

What changed? Added some extra test cases to increase coverage for some stray lines that were missed in previous PRs.

Why? code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.08%. Comparing base (ab0d875) to head (723c0ec). Report is 8 commits behind head on master.

Additional details and impacted files [see 19 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6098/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6098?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6098?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [ab0d875...723c0ec](https://app.codecov.io/gh/uber/cadence/pull/6098?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 018fe51b-e6eb-4b35-9fd1-9ff51a8e73b0

Details

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/fifo_task_scheduler.go 2 85.57%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 77.72%
common/persistence/historyManager.go 2 66.67%
service/history/handler/handler.go 3 96.2%
service/history/engine/engineimpl/reset_sticky_tasklist.go 6 66.67%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
service/frontend/api/handler.go 24 65.45%
service/history/shard/context.go 52 69.17%
<!-- Total: 766 -->
Totals Coverage Status
Change from base Build 018fe4fa-880c-4efc-b964-4cf1474664a6: -0.4%
Covered Lines: 104579
Relevant Lines: 148950
💛 - Coveralls