search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Add unit tests for matching engine #6102

Closed Shaddoll closed 3 weeks ago

Shaddoll commented 3 weeks ago

What changed?

Why? Improve coverage

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.31%. Comparing base (b38bd0c) to head (c98a6d2). Report is 5 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6102?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/matching/handler/engine.go](https://app.codecov.io/gh/uber/cadence/pull/6102?src=pr&el=tree&filepath=service%2Fmatching%2Fhandler%2Fengine.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy9oYW5kbGVyL2VuZ2luZS5nbw==) | `77.14% <100.00%> (+20.66%)` | :arrow_up: | | [service/matching/tasklist/task\_list\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6102?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_list_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2xpc3RfbWFuYWdlci5nbw==) | `63.70% <ø> (ø)` | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6102/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6102?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6102?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [b38bd0c...c98a6d2](https://app.codecov.io/gh/uber/cadence/pull/6102?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).