uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Call GetDomainName once in task_list_mngr:NewManager() #6107

Closed dkrotx closed 3 weeks ago

dkrotx commented 3 weeks ago

This makes newTaskListConfig error-less as it should be (since it just produces config)

refactoring to make newTaskListConfig return just config, not config & error

small refactoring during deep dive

How did you test it?

Potential risks

Release notes

Documentation Changes

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fe9f1-e8d5-448d-bef6-0d3f91465651

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/matching/tasklist/task_list_manager.go 2 76.65%
common/task/fifo_task_scheduler.go 2 87.63%
service/matching/tasklist/matcher.go 2 89.35%
service/history/task/task.go 3 84.81%
service/history/task/timer_active_task_executor.go 3 79.33%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 3 86.6%
bench/lib/client.go 4 0.0%
service/matching/config/config.go 4 91.49%
<!-- Total: 144 -->
Totals Coverage Status
Change from base Build 018fe9e9-5b1b-4b55-a4a1-8f985d11d2a5: -0.07%
Covered Lines: 105257
Relevant Lines: 148947

💛 - Coveralls